Stream: git-wasmtime

Topic: wasmtime / PR #6701 allow perfmaps on any unix platform

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:31):

Maaarcocr opened PR #6701 from Maaarcocr:main to bytecodealliance:main:

why?

perfmaps are fairly simple files that are written to /tmp/ and that are read by perf. It does kind of make sense to have them only work for linux, but with more modern profilers also adopting some of the perf standards like samply, which can run both on linux and on macos, it may make sense to be able to produce these artefacts also on macos.

I know that samply does already support jitdumps, but currently the jitdump implementation here cannot run outside of linux as it uses gettid. Samply also supports perf maps, on both linux and macos, and the perf map implementation here is fairly simple and can run on both platforms.

This would be very beneficial for developers using macos to their code.

how?

change the cfg! statement to compile for all unix platforms.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:31):

Maaarcocr requested alexcrichton for a review on PR #6701.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:31):

Maaarcocr requested wasmtime-core-reviewers for a review on PR #6701.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:39):

bjorn3 created PR review comment:

Can you also change this in cranelift/jit?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:39):

bjorn3 edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:49):

Maaarcocr requested cfallin for a review on PR #6701.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:49):

Maaarcocr updated PR #6701.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:49):

Maaarcocr requested wasmtime-compiler-reviewers for a review on PR #6701.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:49):

Maaarcocr created PR review comment:

done!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 10:54):

bjorn3 created PR review comment:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 14:23):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 07 2023 at 15:11):

alexcrichton merged PR #6701.

Last updated: Nov 22 2024 at 17:03 UTC