Stream: git-wasmtime

Topic: wasmtime / PR #6700 winch(x64) Add support for local tee

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:10):

saulecabrera opened PR #6700 from saulecabrera:winch-local-tee to bytecodealliance:main:

This commit adds support for the local.tee instruction. This change also introduces a refactoring to the original implementation of local.set to be able to share most of the code for the implementation of local.tee.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:10):

saulecabrera requested fitzgen for a review on PR #6700.

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:10):

saulecabrera requested wasmtime-fuzz-reviewers for a review on PR #6700.

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:10):

saulecabrera requested wasmtime-core-reviewers for a review on PR #6700.

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:10):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #6700.

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:10):

saulecabrera requested cfallin for a review on PR #6700.

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:20):

cfallin submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:20):

cfallin submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:20):

cfallin created PR review comment:

This comment is a little ambiguous, especially in combination with the context of local.tee -- I would expect it to use the value at the TOS, but not pop it. Could we say "Pops the value at the stack top and assigns it to the local ..."?

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:26):

saulecabrera updated PR #6700.

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:26):

saulecabrera created PR review comment:

Sure, that makes sense to me. Done, thanks!

Wasmtime GitHub notifications bot (Jul 06 2023 at 22:30):

saulecabrera has enabled auto merge for PR #6700.

Wasmtime GitHub notifications bot (Jul 06 2023 at 23:38):

saulecabrera merged PR #6700.

Last updated: Dec 23 2024 at 12:05 UTC