Stream: git-wasmtime

Topic: wasmtime / PR #6694 Fix signatures registered with module...

Wasmtime GitHub notifications bot (Jul 05 2023 at 21:48):

alexcrichton opened PR #6694 from alexcrichton:fix-component-wasm-to-native-trampolines to bytecodealliance:main:

This commit fixes a minor issue in
FunctionIndices::link_and_append_code which previously ended up only filling out the wasm_to_native_trampolines field for the first module rather than all the modules. Additionally the first module might have too many entries that encompass all modules instead of just its own entries. The fix in this commit is to refactor this logic to ensure that the necessary maps are present for all translations.

While technically a bug that can be surfaced through the embedder API it's pretty obscure. The given test here panics beforehand but succeeds afterwards, but this is moreso prep for some future resource-related work where this map will need persisting into the component metadata side of things.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 05 2023 at 21:48):

alexcrichton requested fitzgen for a review on PR #6694.

Wasmtime GitHub notifications bot (Jul 05 2023 at 21:48):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6694.

Wasmtime GitHub notifications bot (Jul 06 2023 at 15:53):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 06 2023 at 16:07):

alexcrichton updated PR #6694.

Wasmtime GitHub notifications bot (Jul 06 2023 at 16:07):

alexcrichton has enabled auto merge for PR #6694.

Wasmtime GitHub notifications bot (Jul 06 2023 at 17:11):

alexcrichton merged PR #6694.

Last updated: Jan 10 2026 at 02:36 UTC