Stream: git-wasmtime

Topic: wasmtime / PR #6692 Fix a typo in an `unsafe impl Send/Sync`

Wasmtime GitHub notifications bot (Jul 05 2023 at 19:41):

alexcrichton opened PR #6692 from alexcrichton:smaller-unsafe-scope to bytecodealliance:main:

This commit fixes a mistake in the PrePatchedFuncRef type where it has an unsafe impl to make it send/sync but the target of the impl was mistakenly InstancePre<T>

Note that this doesn't actually have any impact on the send/sync-ness of InstancePre<T> since it's not storing an instance of T, so it's always Send/Sync anyway. Nevertheless this reduces the scope of unsafety slightly as was originally intended.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 05 2023 at 19:41):

alexcrichton requested fitzgen for a review on PR #6692.

Wasmtime GitHub notifications bot (Jul 05 2023 at 19:41):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6692.

Wasmtime GitHub notifications bot (Jul 05 2023 at 20:46):

jameysharp submitted PR review:

This makes sense. But since this was passing CI before, I guess that nothing was depending on PrePatchedFuncRef being Send or Sync, so do we need those at all? Could these unsafe impls just be deleted instead?

Wasmtime GitHub notifications bot (Jul 05 2023 at 20:58):

alexcrichton updated PR #6692.

Wasmtime GitHub notifications bot (Jul 05 2023 at 23:26):

alexcrichton merged PR #6692.

Last updated: Oct 23 2024 at 20:03 UTC