Stream: git-wasmtime

Topic: wasmtime / PR #6683 cranelift: Const Propagate `ireduce`

view this post on Zulip Wasmtime GitHub notifications bot (Jul 04 2023 at 11:35):

afonso360 opened PR #6683 from afonso360:cprop-ireduce to bytecodealliance:main:

:wave: Hey,

I was playing around with cranelift over the weekend, and found that we currently don't have a cprop rule for ireduce, in my case this was preventing a bunch of the other optimizations from running.

I've also added some tests for the other extends which were missing.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 04 2023 at 11:35):

afonso360 requested elliottt for a review on PR #6683.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 04 2023 at 11:36):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6683.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2023 at 17:15):

elliottt submitted PR review:

Looks good to me!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2023 at 17:15):

elliottt submitted PR review:

Looks good to me!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2023 at 17:15):

elliottt created PR review comment:

Is it worth adding the fits_in_64 check here anyway just to future-proof this a bit?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2023 at 20:09):

afonso360 updated PR #6683.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2023 at 20:11):

afonso360 has enabled auto merge for PR #6683.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 05 2023 at 21:12):

afonso360 merged PR #6683.

Last updated: Nov 22 2024 at 17:03 UTC