alexcrichton opened PR #6676 from alexcrichton:wasm-call-conv
to bytecodealliance:main
:
This resolves two issues from recent changes in #6649:
First the s390x calling convention for wasm functions is changed back to
WasmtimeSystemV
fromFast
. This was an accidental omission from #6649 where the conclusion was that s390x will continue using a calling convention with little-endian lane order for lane arguments. The only calling convention that supports this today isWasmtimeSystemV
, although theTail
calling convention will likely use it in the future as well.Second the apple-aarch64 platform now uses the
Fast
calling convention instead ofAppleAarch64
calling convention. That convention was specified in #4195 but local testing shows that is not necessary in the sense that tests all pass with theFast
calling convention. This means that the prior comment why theAppleAarch64
calling convention is required is no longer accurate and in the absence of a reason not to I went ahead and switched it toFast
.In the near future all wasm functions will unconditionally use the
Tail
calling convention and at that time the lane order can be specified on s390x to be little-endian to satisfy all the constraints here. Additionally any unwinding directives, if necessary for aarch64, can be specified as needed.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested itsrainy for a review on PR #6676.
alexcrichton requested wasmtime-core-reviewers for a review on PR #6676.
alexcrichton updated PR #6676.
fitzgen submitted PR review.
fitzgen merged PR #6676.
Last updated: Dec 23 2024 at 12:05 UTC