Stream: git-wasmtime

Topic: wasmtime / PR #6669 Add `WasiCtxBuilder` setters for the ...

Wasmtime GitHub notifications bot (Jun 29 2023 at 11:29):

rylev opened PR #6669 from rylev:clock-setters to bytecodealliance:main:

This allows users to set individual clock types on the WasiCtxBuilder.

Before

let mut clocks = clocks_ctx();
clocks.wall = Box::new(MyWallClock);
builder.set_clocks(clocks)

After

builder.set_wall_clock(MyWallClock)

I didn't add any documentation because most of the other setters don't have any, and I was unsure what form the documentation should take.

Wasmtime GitHub notifications bot (Jun 29 2023 at 11:29):

rylev requested alexcrichton for a review on PR #6669.

Wasmtime GitHub notifications bot (Jun 29 2023 at 11:29):

rylev requested wasmtime-core-reviewers for a review on PR #6669.

Wasmtime GitHub notifications bot (Jun 30 2023 at 12:24):

rylev updated PR #6669.

Wasmtime GitHub notifications bot (Jun 30 2023 at 15:24):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 30 2023 at 15:43):

pchickey submitted PR review:

Looks good - thank you. One last suggestion if you're up to it - in the past I used the convention WasiThing to name the host types, but as we shifted to the component model, I've preferred HostThing instead - would you mind renaming these HostMonotonicClock and HostWallClock?

Also I'm not sure if the +Send+Sync in each box is required since those traits already require send and sync, maybe those could have been removed a while ago...

Wasmtime GitHub notifications bot (Jun 30 2023 at 16:27):

rylev updated PR #6669.

Wasmtime GitHub notifications bot (Jun 30 2023 at 20:38):

rylev updated PR #6669.

Wasmtime GitHub notifications bot (Jun 30 2023 at 23:07):

alexcrichton merged PR #6669.

Last updated: Nov 22 2024 at 17:03 UTC