Stream: git-wasmtime

Topic: wasmtime / PR #6663 cranelift: Support calling functions ...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2023 at 16:55):

afonso360 opened PR #6663 from afonso360:filetests-support-vmctx to bytecodealliance:main:

This is a leftover from #3302 where we used to inject a special vmctx struct if the test requested it. We've removed that capability in #5386 but accidentally left this in, which caused some weird handling of these test invocations.

Fixes #6659

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2023 at 16:55):

afonso360 requested cfallin for a review on PR #6663.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2023 at 16:55):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6663.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2023 at 16:55):

afonso360 requested fitzgen for a review on PR #6663.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2023 at 17:03):

fitzgen submitted PR review:

Whoops, this was my fault that it wasn't fully removed when we removed heaps from clif.

Thanks!!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2023 at 17:03):

fitzgen has enabled auto merge for PR #6663.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 28 2023 at 18:15):

fitzgen merged PR #6663.

Last updated: Dec 23 2024 at 12:05 UTC