Stream: git-wasmtime

Topic: wasmtime / PR #6651 Cranelift: Choose different temporary...

Wasmtime GitHub notifications bot (Jun 27 2023 at 18:33):

fitzgen opened PR #6651 from fitzgen:issue-6640 to bytecodealliance:main:

On x86_64, for example, the temporary register was previously hardcoded to r11 which was available as a non-argument, caller-saved register on both system v and fast call. However in the tail calling convention it is used as an argument register.

This commit plumbs through the calling convention to where we are choosing a temporary register for stack probes so that we can make an informed decision.

Fixes #6640

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 27 2023 at 18:33):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #6651.

Wasmtime GitHub notifications bot (Jun 27 2023 at 18:33):

fitzgen requested cfallin for a review on PR #6651.

Wasmtime GitHub notifications bot (Jun 27 2023 at 18:33):

fitzgen requested alexcrichton for a review on PR #6651.

Wasmtime GitHub notifications bot (Jun 27 2023 at 18:33):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #6651.

Wasmtime GitHub notifications bot (Jun 27 2023 at 18:40):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 27 2023 at 20:14):

fitzgen merged PR #6651.

Last updated: Dec 23 2024 at 12:05 UTC