Stream: git-wasmtime

Topic: wasmtime / PR #6650 Cranelift: Leave the return address i...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2023 at 17:16):

fitzgen opened PR #6650 from fitzgen:leave-return-address-in-place-for-most-tail-calls to bytecodealliance:main:

When the size of the tail callee's and tail caller's stack arguments is the same, we don't need to copy the return address and then write it to the stack again, since its original location will also be its final location. That is, we were previously reading a value and then writing it back to the exact same location.

Builds on top of https://github.com/bytecodealliance/wasmtime/pull/6635

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2023 at 17:16):

fitzgen requested cfallin for a review on PR #6650.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2023 at 17:16):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #6650.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2023 at 18:04):

cfallin submitted PR review:

LGTM on last commit!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2023 at 18:10):

fitzgen updated PR #6650.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2023 at 18:10):

fitzgen has enabled auto merge for PR #6650.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 27 2023 at 19:34):

fitzgen merged PR #6650.


Last updated: Dec 23 2024 at 12:05 UTC