Wasmtime GitHub notifications bot (Jun 23 2023 at 02:29): Wasmtime GitHub notifications bot (Jun 23 2023 at 02:29):alexcrichton opened PR #6634 from alexcrichton:fix-aarch64-authenticate-ret-pop-bytes to bytecodealliance:main:
This commit fixes an accidental issue with #6478 where when pointer authentication was enabled and stack bytes are being popped during a return this didn't work. In this situation an authenticated return instruction was used, such as
retab, and no extra stack bytes were popped. The fix here is to use the non-retabpath which handles stack bytes being popped if there are stack bytes to pop.Closes #6567
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 23 2023 at 02:29):alexcrichton requested elliottt for a review on PR #6634.
Wasmtime GitHub notifications bot (Jun 23 2023 at 02:29):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6634.
Wasmtime GitHub notifications bot (Jun 23 2023 at 03:43):alexcrichton updated PR #6634.
Wasmtime GitHub notifications bot (Jun 23 2023 at 07:24):elliottt submitted PR review:
Nice!
Wasmtime GitHub notifications bot (Jun 23 2023 at 14:18):alexcrichton merged PR #6634.
Last updated: Dec 23 2024 at 12:05 UTC