Stream: git-wasmtime

Topic: wasmtime / PR #6631 cranelift: Remove the `enable_simd` s...

Wasmtime GitHub notifications bot (Jun 22 2023 at 19:58):

alexcrichton opened PR #6631 from alexcrichton:remove-enable-simd to bytecodealliance:main:

This commit removes a setting for Cranelift which I've found a bit confusing historically and I think is no longer necessary. The setting is currently documented as enabling SIMD instructions, but that only sort of works for the x64 backend and none of the other backends look at it. Historically this was used to flag to Cranelift that a higher x64 baseline feature set is required for codegen but as of #6625 that's no longer necessary.

Otherwise it seems more Cranelift-like nowadays to say that vector instructions generate SIMD instructions where non-vector instructions probably don't, but may still depending on activated CPU features. In that sense I'm not sure if a dedicated enable_simd setting is still motivated, so this PR removes it.

This renames some features in the x86 backend such as use_avx_simd to use_avx since the _simd part is no longer part of the computation now that enable_simd is gone.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 22 2023 at 19:58):

alexcrichton requested fitzgen for a review on PR #6631.

Wasmtime GitHub notifications bot (Jun 22 2023 at 19:58):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6631.

Wasmtime GitHub notifications bot (Jun 22 2023 at 19:58):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6631.

Wasmtime GitHub notifications bot (Jun 22 2023 at 22:13):

fitzgen submitted PR review:

\o/

Wasmtime GitHub notifications bot (Jun 22 2023 at 22:54):

fitzgen merged PR #6631.

Last updated: Dec 23 2024 at 12:05 UTC