Stream: git-wasmtime

Topic: wasmtime / PR #6629 x64: Fix ISA requirement for `pmaddubsw`


view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2023 at 19:36):

alexcrichton opened PR #6629 from alexcrichton:x64-sse2-pmaddubsw to bytecodealliance:main:

This was erroneously listed as SSE2 but this is actually an SSSE3 instruction. This commit updates the ISA requirement as well as related lowerings to have everything work with an SSE2 baseline as well which is mostly plumbing to make sure the relaxed-simd dot product instructions use it when it's available but otherwise fall-back to the deterministic lowering.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2023 at 19:36):

alexcrichton requested abrown for a review on PR #6629.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2023 at 19:36):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6629.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2023 at 19:37):

alexcrichton requested pchickey for a review on PR #6629.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2023 at 19:37):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6629.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2023 at 19:38):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2023 at 23:25):

alexcrichton updated PR #6629.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 22 2023 at 23:25):

alexcrichton has enabled auto merge for PR #6629.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 23 2023 at 00:43):

alexcrichton merged PR #6629.


Last updated: Oct 23 2024 at 20:03 UTC