Stream: git-wasmtime

Topic: wasmtime / PR #6621 Cranelift: Add methods for adjusting ...

Wasmtime GitHub notifications bot (Jun 21 2023 at 21:57):

fitzgen edited PR #6621:

Gives us a single place to trace! log state changes and prevents things from getting out of sync in the future.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 21 2023 at 21:59):

fitzgen requested jameysharp for a review on PR #6621.

Wasmtime GitHub notifications bot (Jun 22 2023 at 05:50):

jameysharp submitted PR review:

Nice refactoring, I like it! I have a couple suggestions, but merge this in whatever form you prefer.

Wasmtime GitHub notifications bot (Jun 22 2023 at 05:50):

jameysharp submitted PR review:

Nice refactoring, I like it! I have a couple suggestions, but merge this in whatever form you prefer.

Wasmtime GitHub notifications bot (Jun 22 2023 at 05:50):

jameysharp created PR review comment:

I'd be inclined to move the new emit_state module to a separate source file rather than keeping it inline here. I don't see inline modules in Rust source very often so I had to think about why you needed a module at all (and figured out the answer). If it's a separate file then I won't wonder about it…

Wasmtime GitHub notifications bot (Jun 22 2023 at 05:50):

jameysharp created PR review comment:

I guess these could be pub(super) instead of pub(crate).

Wasmtime GitHub notifications bot (Jun 22 2023 at 17:26):

fitzgen updated PR #6621.

Wasmtime GitHub notifications bot (Jun 22 2023 at 17:27):

fitzgen created PR review comment:

I personally don't find benefit in trying to be super precise about these sort of things, and a coarseness of pub vs pub(crate) is generally good enough.

Wasmtime GitHub notifications bot (Jun 22 2023 at 17:27):

fitzgen created PR review comment:

Good call, done!

Wasmtime GitHub notifications bot (Jun 22 2023 at 17:27):

fitzgen has enabled auto merge for PR #6621.

Wasmtime GitHub notifications bot (Jun 22 2023 at 18:28):

fitzgen merged PR #6621.

Last updated: Dec 23 2024 at 13:07 UTC