Stream: git-wasmtime

Topic: wasmtime / PR #6613 Issue-6592: ArgsAccumulator should ma...

Wasmtime GitHub notifications bot (Jun 21 2023 at 05:22):

ilikepi63 edited PR #6613:

Issue # 6592

Add non formal Arguments to the ArgsAccumulator struct.

Wasmtime GitHub notifications bot (Jun 21 2023 at 06:03):

elliottt submitted PR review:

Thanks for taking this on! Would you mind modifying the implementations of compute_arg_locs for x64 and aarch64 to use your new push_non_formal method when pushing an argument for the add_ret_area_ptr case? That way we'll exercise the debug assert that you added :)

Wasmtime GitHub notifications bot (Jun 21 2023 at 06:45):

ilikepi63 updated PR #6613.

Wasmtime GitHub notifications bot (Jun 21 2023 at 10:54):

ilikepi63 requested elliottt for a review on PR #6613.

Wasmtime GitHub notifications bot (Jun 22 2023 at 18:17):

elliottt submitted PR review:

This looks good to me, thank you!

Wasmtime GitHub notifications bot (Jun 22 2023 at 18:17):

elliottt edited PR #6613:

Issue # 6592

Add non formal Arguments to the ArgsAccumulator struct.

Fixes: #6592

Wasmtime GitHub notifications bot (Jun 22 2023 at 19:03):

elliottt merged PR #6613.

Last updated: Dec 23 2024 at 12:05 UTC