Wasmtime GitHub notifications bot (Jun 20 2023 at 00:15): Wasmtime GitHub notifications bot (Jun 20 2023 at 00:15):alexcrichton opened PR #6606 from alexcrichton:x64-sse2-pshufb to bytecodealliance:main:
Or, more accurately, add lowerings which don't use
pshufb's functionality at all where possible or otherwise fall back to a new libcall. This particular instruction seemed uniquely difficult to implement in the backend so I decided to "cop out" and use libcall instead. The libcall will be used forpopcnt,shuffle, andswizzleinstructions when SSSE3 isn't available.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 20 2023 at 00:15):alexcrichton requested abrown for a review on PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 00:15):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 00:15):alexcrichton requested wasmtime-core-reviewers for a review on PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 00:15):alexcrichton requested fitzgen for a review on PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 02:03):alexcrichton updated PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 02:50):alexcrichton updated PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 03:42):alexcrichton updated PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 15:10):alexcrichton requested wasmtime-default-reviewers for a review on PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 15:10):alexcrichton updated PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 15:14):alexcrichton updated PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 17:19):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 20 2023 at 17:19):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 20 2023 at 17:19):fitzgen created PR review comment:
Is this still necessary? I'm not seeing any
.clone()s here.
Wasmtime GitHub notifications bot (Jun 20 2023 at 17:19):fitzgen created PR review comment:
File a follow up issue to track this?
Wasmtime GitHub notifications bot (Jun 20 2023 at 17:39):alexcrichton updated PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 17:40):alexcrichton created PR review comment:
Oops, indeed!
Wasmtime GitHub notifications bot (Jun 20 2023 at 17:41):alexcrichton created PR review comment:
Ah this ended up actually being necessary to fill out, so no longer relevant (sorry I probably pushed to the PR while you were reviewing)
Wasmtime GitHub notifications bot (Jun 20 2023 at 17:44):alexcrichton has enabled auto merge for PR #6606.
Wasmtime GitHub notifications bot (Jun 20 2023 at 19:06):alexcrichton merged PR #6606.
Last updated: Oct 23 2024 at 20:03 UTC