Stream: git-wasmtime

Topic: wasmtime / PR #6599 riscv64: Add SIMD `avg_round`

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 12:01):

afonso360 opened PR #6599 from afonso360:riscv-simd-avg-round to bytecodealliance:main:

:wave: Hey,

This PR implements the SIMD avg_round instruction. We don't have a native version of this, so we break it down into multiple ops, using a slightly modified formula from Hacker's Delight.

The original formula does a floor average round, but we correct that by using a special shift right instruction that rounds up the result. I think this is correct, but would appreciate a double check on it.

This passes both the cranelift tests, as well as the wasmtime *_arith2 test suites, however we can't enable them yet because they also require iabs which is only implemented in #6598.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 12:01):

afonso360 requested abrown for a review on PR #6599.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 12:01):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6599.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 17:31):

alexcrichton submitted PR review:

:+1:

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 19:09):

afonso360 merged PR #6599.

Last updated: Dec 23 2024 at 12:05 UTC