Stream: git-wasmtime

Topic: wasmtime / PR #6597 Fix inconsistent deadlines for monoto...


view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 01:58):

sunfishcode opened PR #6597 from sunfishcode:sunfishcode/monotonic-deadline to bytecodealliance:main:

Rename MonotonicClockSubscription's deadline field to absolute_deadline and change the code that computes the value to compute an absolute time rather than a relative time, so that it's interpreted consistently everywhere.

Fixes #6588.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 01:58):

sunfishcode requested alexcrichton for a review on PR #6597.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 01:58):

sunfishcode requested wasmtime-core-reviewers for a review on PR #6597.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 04:08):

sunfishcode updated PR #6597.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 04:30):

sunfishcode updated PR #6597.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 05:18):

sunfishcode updated PR #6597.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 17 2023 at 17:32):

alexcrichton submitted PR review:

Seems like a good refactoring :+1:

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2023 at 16:35):

sunfishcode updated PR #6597.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2023 at 21:54):

sunfishcode updated PR #6597.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 20 2023 at 22:02):

pchickey has enabled auto merge for PR #6597.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 21 2023 at 13:29):

sunfishcode merged PR #6597.


Last updated: Oct 23 2024 at 20:03 UTC