Stream: git-wasmtime

Topic: wasmtime / PR #6596 Add a `set_random` function to `WasiC...

Wasmtime GitHub notifications bot (Jun 17 2023 at 01:15):

sunfishcode opened PR #6596 from sunfishcode:sunfishcode/set-random to bytecodealliance:main:

Add a set_random function to WasiCtxBuilder, allowing users that construct a default interface via WasiCtxBuilder::default() or WasiCtx::builder() to initialize the random state.

Fixes #6576.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 17 2023 at 01:15):

sunfishcode requested itsrainy for a review on PR #6596.

Wasmtime GitHub notifications bot (Jun 17 2023 at 01:15):

sunfishcode requested wasmtime-core-reviewers for a review on PR #6596.

Wasmtime GitHub notifications bot (Jun 17 2023 at 01:22):

sunfishcode updated PR #6596.

Wasmtime GitHub notifications bot (Jun 17 2023 at 04:39):

alexcrichton created PR review comment:

I'm not sure of the underlying motivations for this, but I would naively expect this to be set_random and not #[cfg(test)] where the new method added in this PR would be something like set_random_randomized (or set_random_system or something like that). While the CLI likely doesn't want set_random_for_testing I could see that being useful in a deterministic record-and-replay sort of scenario

Wasmtime GitHub notifications bot (Jun 20 2023 at 17:16):

sunfishcode updated PR #6596.

Wasmtime GitHub notifications bot (Jun 20 2023 at 17:41):

sunfishcode updated PR #6596.

Wasmtime GitHub notifications bot (Jun 20 2023 at 17:44):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jun 22 2023 at 15:19):

sunfishcode updated PR #6596.

Wasmtime GitHub notifications bot (Jun 22 2023 at 16:59):

sunfishcode merged PR #6596.

Last updated: Nov 22 2024 at 17:03 UTC