Wasmtime GitHub notifications bot (Jun 14 2023 at 13:53): Wasmtime GitHub notifications bot (Jun 14 2023 at 13:53):alexcrichton opened PR #6580 from alexcrichton:x64-iabs-sse2 to bytecodealliance:main:
Use instruction patterns modeled after LLVM's output for these lowerings.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 14 2023 at 13:53):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6580.
Wasmtime GitHub notifications bot (Jun 14 2023 at 13:53):alexcrichton requested abrown for a review on PR #6580.
Wasmtime GitHub notifications bot (Jun 15 2023 at 23:02):abrown submitted PR review:
LGTM!
Wasmtime GitHub notifications bot (Jun 15 2023 at 23:02):abrown submitted PR review:
LGTM!
Wasmtime GitHub notifications bot (Jun 15 2023 at 23:02):abrown created PR review comment:
Can you remind me what
1means here? Does it mean "higher priority", so the SSSE3 condition is checked _before_ we emit the long sequence?
Wasmtime GitHub notifications bot (Jun 15 2023 at 23:18):alexcrichton created PR review comment:
Indeed! Rules are match in-order highest-to-lowest priority and the first matching one is the one used for lowering. Rules then aren't allowed to overlap at all which is why a priority is required here because otherwise if
use_ssse3istruethen it's ambiguous which rule to use here (so the priority says check this one first)
Wasmtime GitHub notifications bot (Jun 16 2023 at 00:03):alexcrichton merged PR #6580.
Last updated: Oct 23 2024 at 20:03 UTC