Stream: git-wasmtime

Topic: wasmtime / PR #6579 fuzzgen: Generate Random Calling Conv...

Wasmtime GitHub notifications bot (Jun 14 2023 at 11:31):

afonso360 opened PR #6579 from afonso360:fuzzgen-calling-convention to bytecodealliance:main:

:wave: Hey,

This PR allows fuzzgen to start using different calling conventions in the functions it generates.

I've disabled the tail calling convention for now since it's causing segfaults on x86 and wrong results on AArch64. (I'm also not sure if I should report that or if that's still expected? cc: @fitzgen )

Wasmtime calling conventions are also disabled since they don't support i128 values, and avoiding generating those is a bit difficult for now.

I've fuzzed this under fuzzgen on both x86 and AArch64 for around an hour and it seems stable.

Wasmtime GitHub notifications bot (Jun 14 2023 at 11:31):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6579.

Wasmtime GitHub notifications bot (Jun 14 2023 at 11:31):

afonso360 requested elliottt for a review on PR #6579.

Wasmtime GitHub notifications bot (Jun 14 2023 at 11:33):

afonso360 updated PR #6579.

Wasmtime GitHub notifications bot (Jun 14 2023 at 15:57):

fitzgen submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (Jun 14 2023 at 15:57):

fitzgen submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (Jun 14 2023 at 15:57):

fitzgen created PR review comment:

        // TODO(#6581, #6582): Enable Tail Calls

Wasmtime GitHub notifications bot (Jun 14 2023 at 15:58):

afonso360 updated PR #6579.

Wasmtime GitHub notifications bot (Jun 14 2023 at 15:59):

afonso360 has enabled auto merge for PR #6579.

Wasmtime GitHub notifications bot (Jun 14 2023 at 17:08):

afonso360 merged PR #6579.

Last updated: Oct 23 2024 at 20:03 UTC