Stream: git-wasmtime

Topic: wasmtime / PR #6564 x64: Move some constants directly in-...

Wasmtime GitHub notifications bot (Jun 12 2023 at 20:11):

alexcrichton requested elliottt for a review on PR #6564.

Wasmtime GitHub notifications bot (Jun 12 2023 at 20:11):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6564.

Wasmtime GitHub notifications bot (Jun 12 2023 at 20:11):

alexcrichton opened PR #6564 from alexcrichton:move-some-constants to bytecodealliance:main:

I believe that historically it was difficult to write a 128-bit constant in ISLE but nowadays ISLE supports u128 integer literals so it's now possible to do that. This commit moves some existing constants in x64/lower/isle.rs into lower.isle directly to more easily understand them when reading over instruction lowerings by avoiding having to context switch between ISLE and Rust to understand the value of a constant.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 12 2023 at 20:48):

elliottt submitted PR review:

Awesome!

Wasmtime GitHub notifications bot (Jun 13 2023 at 14:31):

alexcrichton merged PR #6564.

Last updated: Oct 23 2024 at 20:03 UTC