Wasmtime GitHub notifications bot (Jun 12 2023 at 19:47): Wasmtime GitHub notifications bot (Jun 12 2023 at 19:47):alexcrichton opened PR #6563 from alexcrichton:fix-splat-regression to bytecodealliance:main:
This commit adds a targeted optimization aimed at fixing #6562 as a temporary measure for now. The "real" fix for #6562 is to add a full lowering of
fcvt_from_uintto the x64 backend, but for now adding this rule should fix the specific issue cropping up.Closes #6562
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 12 2023 at 19:47):alexcrichton requested jameysharp for a review on PR #6563.
Wasmtime GitHub notifications bot (Jun 12 2023 at 19:47):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6563.
Wasmtime GitHub notifications bot (Jun 12 2023 at 19:47):alexcrichton requested wasmtime-core-reviewers for a review on PR #6563.
Wasmtime GitHub notifications bot (Jun 12 2023 at 19:50):jameysharp submitted PR review:
Great, thank you!
Wasmtime GitHub notifications bot (Jun 12 2023 at 20:02):alexcrichton has enabled auto merge for PR #6563.
Wasmtime GitHub notifications bot (Jun 12 2023 at 20:50):alexcrichton merged PR #6563.
Last updated: Dec 23 2024 at 12:05 UTC