Stream: git-wasmtime

Topic: wasmtime / PR #6557 Add clz and ctz instructions to Winch

Wasmtime GitHub notifications bot (Jun 09 2023 at 21:26):

jeffcharles opened PR #6557 from jeffcharles:winch-add-unary-instructions to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Add support for clz and ctz instructions to Winch. Also adds passing CPU flags to filetests.

Wasmtime GitHub notifications bot (Jun 09 2023 at 21:26):

jeffcharles requested elliottt for a review on PR #6557.

Wasmtime GitHub notifications bot (Jun 09 2023 at 21:26):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #6557.

Wasmtime GitHub notifications bot (Jun 09 2023 at 21:26):

jeffcharles requested wasmtime-fuzz-reviewers for a review on PR #6557.

Wasmtime GitHub notifications bot (Jun 12 2023 at 14:06):

saulecabrera submitted PR review:

Looks good to me -- I think that given the tricky bits on the fallback implementation of both instructions it's probably a good idea to ask @cfallin or @elliottt (if you're feeling up for it, given that you're in the PR) to take another look before landing it.

Wasmtime GitHub notifications bot (Jun 12 2023 at 14:08):

saulecabrera submitted PR review:

Looks good to me -- I think that given the tricky bits on the fallback implementation of both instructions it's probably a good idea to ask @cfallin or @elliottt (if you're feeling up for it, given that you're already in the PR) to take another look before landing it.

Wasmtime GitHub notifications bot (Jun 12 2023 at 16:00):

cfallin submitted PR review:

The fallback cases on x64 look good to me -- nice work!

Wasmtime GitHub notifications bot (Jun 12 2023 at 16:51):

saulecabrera merged PR #6557.

Last updated: Dec 23 2024 at 12:05 UTC