Stream: git-wasmtime

Topic: wasmtime / PR #6549 cranelift: don't enable trace-log fea...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2023 at 16:58):

jameysharp opened PR #6549 from jameysharp:disable-default-trace-log to bytecodealliance:main:

In #5382 ("egraph support: rewrite to work in terms of CLIF data structures"), we added the trace-log feature to the set of default features for cranelift-codegen. I think this was an accident, probably added while debugging and overlooked when cleaning up to merge.

So let's undo that change. Fixes #6548.

Does anyone have strong opinions for or against backporting this for the upcoming release?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2023 at 16:58):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #6549.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2023 at 16:58):

jameysharp requested fitzgen for a review on PR #6549.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2023 at 17:40):

abrown submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2023 at 18:09):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 09 2023 at 18:28):

jameysharp merged PR #6549.

Last updated: Nov 22 2024 at 16:03 UTC