Stream: git-wasmtime

Topic: wasmtime / PR #6538 Add integer binary instructions to Winch

Wasmtime GitHub notifications bot (Jun 07 2023 at 18:47):

jeffcharles opened PR #6538 from jeffcharles:winch-add-int-binary-instructions to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Part of #6528. Adds x86 support for a number of integer binary instructions to Winch.

Wasmtime GitHub notifications bot (Jun 07 2023 at 18:47):

jeffcharles requested alexcrichton for a review on PR #6538.

Wasmtime GitHub notifications bot (Jun 07 2023 at 18:47):

jeffcharles requested wasmtime-fuzz-reviewers for a review on PR #6538.

Wasmtime GitHub notifications bot (Jun 07 2023 at 18:47):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #6538.

Wasmtime GitHub notifications bot (Jun 07 2023 at 18:47):

jeffcharles requested abrown for a review on PR #6538.

Wasmtime GitHub notifications bot (Jun 07 2023 at 21:23):

saulecabrera submitted PR review:

Left one comment regarding handling of invalid operand combinations. After that I think we can get this landed.

Wasmtime GitHub notifications bot (Jun 07 2023 at 21:23):

saulecabrera submitted PR review:

Left one comment regarding handling of invalid operand combinations. After that I think we can get this landed.

Wasmtime GitHub notifications bot (Jun 07 2023 at 21:23):

saulecabrera created PR review comment:

I believe for this and all the other functions below, we can use Self::handle_invalid_operand_combination?

Wasmtime GitHub notifications bot (Jun 07 2023 at 21:28):

jeffcharles created PR review comment:

I also noticed I can substitute self.load_constant for self.move_ir when loading a larger than 32-bit integer into the scratch register so I'll make that change too.

Wasmtime GitHub notifications bot (Jun 07 2023 at 21:30):

jeffcharles updated PR #6538.

Wasmtime GitHub notifications bot (Jun 07 2023 at 21:30):

jeffcharles requested saulecabrera for a review on PR #6538.

Wasmtime GitHub notifications bot (Jun 07 2023 at 22:03):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jun 07 2023 at 22:57):

saulecabrera merged PR #6538.

Last updated: Oct 23 2024 at 20:03 UTC