Wasmtime GitHub notifications bot (Jun 07 2023 at 13:49): Wasmtime GitHub notifications bot (Jun 07 2023 at 13:49):saulecabrera opened PR #6535 from saulecabrera:winch-fix-pop-to-reg to bytecodealliance:main:
This commit fixes the implementation of
pop_to_reg. In the previous implementation, whenever a specific register was requested as the destination register and a register-to-register moved happened the source register was never marked as free.This issue became more evident with more complex programs involving control flow and division for example.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 07 2023 at 13:49):saulecabrera requested elliottt for a review on PR #6535.
Wasmtime GitHub notifications bot (Jun 07 2023 at 13:49):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #6535.
Wasmtime GitHub notifications bot (Jun 07 2023 at 13:49):saulecabrera requested cfallin for a review on PR #6535.
Wasmtime GitHub notifications bot (Jun 07 2023 at 20:58):elliottt submitted PR review:
Looks good!
Wasmtime GitHub notifications bot (Jun 07 2023 at 22:36):saulecabrera merged PR #6535.
Last updated: Dec 23 2024 at 13:07 UTC