Stream: git-wasmtime

Topic: wasmtime / PR #6518 riscv64: Fix wrong move instruction i...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2023 at 21:04):

afonso360 opened PR #6518 from afonso360:riscv-fix-select-reg to bytecodealliance:main:

:wave: Hey,

This PR fixes an issue with select when used with float registers. We always emit an integer move, but gen_select_reg is sometimes used with float arguments. When this happens emit instead a float move.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2023 at 21:04):

afonso360 requested jameysharp for a review on PR #6518.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2023 at 21:04):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6518.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2023 at 21:04):

afonso360 edited PR #6518:

:wave: Hey,

This PR fixes an issue with select when used with float registers. We always emit an integer move, but gen_select_reg is sometimes used with float arguments. When this happens, emit instead a float move.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 06 2023 at 17:40):

jameysharp submitted PR review:

This makes sense, thank you!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 06 2023 at 18:59):

afonso360 merged PR #6518.

Last updated: Dec 23 2024 at 13:07 UTC