Stream: git-wasmtime

Topic: wasmtime / PR #6512 aarch64: Use Imm12 in more cases

view this post on Zulip Wasmtime GitHub notifications bot (Jun 02 2023 at 21:58):

jameysharp opened PR #6512 from jameysharp:arm-imm12-fix to bytecodealliance:main:

The previous implementation of Imm12::maybe_from_u64 did not match the constant values 0xfff or 0xfff000, even though those are expressible in the aarch64 12-bit immediate format.

Also the explicit test for 0 was unnecessary; it's a valid example of all bits outside the least-significant 12 bits being 0.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 02 2023 at 21:58):

jameysharp requested cfallin for a review on PR #6512.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 02 2023 at 21:58):

jameysharp requested wasmtime-compiler-reviewers for a review on PR #6512.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2023 at 02:06):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2023 at 02:51):

alexcrichton merged PR #6512.

Last updated: Dec 23 2024 at 12:05 UTC