Stream: git-wasmtime

Topic: wasmtime / PR #6511 Use two operands for Winch's masm cmp...

Wasmtime GitHub notifications bot (Jun 02 2023 at 17:40):

jeffcharles opened PR #6511 from jeffcharles:winch-refactor-cmp-with-set-args to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
A refactoring which changes Winch's masm's cmp_with_set method to take src and dst parameters instead of lhs, rhs, and dst parameters since all ISAs supported by Cranelift use 2 operand form for comparison.

Wasmtime GitHub notifications bot (Jun 02 2023 at 17:40):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #6511.

Wasmtime GitHub notifications bot (Jun 02 2023 at 17:40):

jeffcharles requested abrown for a review on PR #6511.

Wasmtime GitHub notifications bot (Jun 02 2023 at 19:36):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2023 at 20:27):

saulecabrera merged PR #6511.

Last updated: Dec 23 2024 at 12:05 UTC