Wasmtime GitHub notifications bot (Jun 02 2023 at 14:05): Wasmtime GitHub notifications bot (Jun 02 2023 at 14:05):afonso360 opened PR #6507 from afonso360:riscv-simd-shifts to bytecodealliance:main:
:wave: Hey,
This PR implements lowerings for SIMD shifts, and a few boolean operations (
v{all,any}_true/vhigh_bits).The implementation for shifts is fairly straight forward, but the boolean operations don't have a equivalent instruction, so we need to do some different operations.
Wasmtime GitHub notifications bot (Jun 02 2023 at 14:05):afonso360 requested elliottt for a review on PR #6507.
Wasmtime GitHub notifications bot (Jun 02 2023 at 14:05):afonso360 requested wasmtime-compiler-reviewers for a review on PR #6507.
Wasmtime GitHub notifications bot (Jun 02 2023 at 14:05):afonso360 requested wasmtime-default-reviewers for a review on PR #6507.
Wasmtime GitHub notifications bot (Jun 02 2023 at 14:46):afonso360 edited PR #6507:
:wave: Hey,
This PR implements lowerings for SIMD shifts, and a few boolean operations (
v{all,any}_true/vhigh_bits).The implementation for shifts is fairly straightforward, but the boolean operations don't have a equivalent instruction, so we need to do some different operations.
Wasmtime GitHub notifications bot (Jun 02 2023 at 16:40):alexcrichton submitted PR review:
All looks good to me, thanks!
For CI abrupt interruptions like that sometimes mean that QEMU is OOM-ing perhaps because of something like the pooling allocator reserving memory or something like that (or perhaps a flaky run, but we don't get many of those). Other than that though I'm not sure what would cause such a failure in CI.
Wasmtime GitHub notifications bot (Jun 03 2023 at 16:35):afonso360 merged PR #6507.
Last updated: Nov 22 2024 at 16:03 UTC