Stream: git-wasmtime

Topic: wasmtime / PR #6506 Refactor Winch x64 asm operand checks

Wasmtime GitHub notifications bot (Jun 02 2023 at 14:02):

jeffcharles opened PR #6506 from jeffcharles:winch-refactor-x64-asm-operand-handling to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Introduce a load_constant method to reduce noise when moving an i64 immediate into a register. Also move the panic for invalid operand combinations into a private method to reduce some repetition.

Wasmtime GitHub notifications bot (Jun 02 2023 at 14:02):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #6506.

Wasmtime GitHub notifications bot (Jun 02 2023 at 14:02):

jeffcharles requested jameysharp for a review on PR #6506.

Wasmtime GitHub notifications bot (Jun 02 2023 at 14:58):

saulecabrera submitted PR review:

LGTM!

Wasmtime GitHub notifications bot (Jun 02 2023 at 15:43):

saulecabrera merged PR #6506.

Last updated: Oct 23 2024 at 20:03 UTC