Stream: git-wasmtime

Topic: wasmtime / PR #6500 Cranelift: Get non-tail calls working...

Wasmtime GitHub notifications bot (Jun 01 2023 at 21:22):

fitzgen opened PR #6500 from fitzgen:tail-call-conv-registers-and-such to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 01 2023 at 21:22):

fitzgen requested abrown for a review on PR #6500.

Wasmtime GitHub notifications bot (Jun 01 2023 at 21:22):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #6500.

Wasmtime GitHub notifications bot (Jun 01 2023 at 22:54):

fitzgen requested cfallin for a review on PR #6500.

Wasmtime GitHub notifications bot (Jun 01 2023 at 23:01):

cfallin submitted PR review:

Looks reasonable. Could we add a comment somewhere noting that for now, the Tail convention is treated the same as SystemV, but is expected to change with subsequent patches? With that noted somewhere, LGTM.

Wasmtime GitHub notifications bot (Jun 01 2023 at 23:10):

fitzgen updated PR #6500.

Wasmtime GitHub notifications bot (Jun 02 2023 at 17:07):

fitzgen updated PR #6500.

Wasmtime GitHub notifications bot (Jun 02 2023 at 17:08):

fitzgen has enabled auto merge for PR #6500.

Wasmtime GitHub notifications bot (Jun 02 2023 at 21:37):

fitzgen updated PR #6500.

Wasmtime GitHub notifications bot (Jun 02 2023 at 22:51):

fitzgen has disabled auto merge for PR #6500.

Wasmtime GitHub notifications bot (Jun 06 2023 at 20:52):

fitzgen updated PR #6500.

Wasmtime GitHub notifications bot (Jun 06 2023 at 20:54):

fitzgen has enabled auto merge for PR #6500.

Wasmtime GitHub notifications bot (Jun 09 2023 at 17:59):

fitzgen updated PR #6500.

Wasmtime GitHub notifications bot (Jun 09 2023 at 19:14):

fitzgen merged PR #6500.

Last updated: Nov 22 2024 at 16:03 UTC