Stream: git-wasmtime

Topic: wasmtime / PR #6498 Wasi: preview2 poll-oneoff returns li...

Wasmtime GitHub notifications bot (Jun 01 2023 at 20:25):

pchickey opened PR #6498 from bytecodealliance:pch/poll_oneoff_return_list_bool to bytecodealliance:main:

In the early days of the preview2 prototype, there was some trouble with wit-bindgen that made it impossible to return a list<bool> from the poll-oneoff function.

This bug has since been resolved. The poll-oneoff definition in wit has been modified to return list<bool> and minor tweaks have been made at use sites to use the boolean.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 01 2023 at 20:25):

pchickey requested fitzgen for a review on PR #6498.

Wasmtime GitHub notifications bot (Jun 01 2023 at 20:25):

pchickey requested wasmtime-core-reviewers for a review on PR #6498.

Wasmtime GitHub notifications bot (Jun 01 2023 at 20:25):

pchickey requested sunfishcode for a review on PR #6498.

Wasmtime GitHub notifications bot (Jun 01 2023 at 21:00):

pchickey updated PR #6498.

Wasmtime GitHub notifications bot (Jun 01 2023 at 22:53):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 11 2023 at 12:34):

sunfishcode closed without merge PR #6498.

Wasmtime GitHub notifications bot (Jun 12 2023 at 17:49):

alexcrichton reopened PR #6498.

Wasmtime GitHub notifications bot (Jun 12 2023 at 20:06):

sunfishcode created PR review comment:

Could you add a comment about why poll-oneoff is skip here, and has manual bindings below instead?

Wasmtime GitHub notifications bot (Jun 27 2023 at 17:26):

pchickey updated PR #6498.

Wasmtime GitHub notifications bot (Jun 27 2023 at 17:26):

pchickey created PR review comment:

https://github.com/bytecodealliance/wasmtime/pull/6498/commits/d76f4f496954ecfa89e98bc9dc239dae8c72a9ce

Wasmtime GitHub notifications bot (Jun 27 2023 at 22:10):

pchickey merged PR #6498.

Last updated: Dec 23 2024 at 12:05 UTC