Stream: git-wasmtime

Topic: wasmtime / PR #6495 Re-enable wasi-http for recent wit bi...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 16:19):

brendandburns opened PR #6495 from brendandburns:renable to bytecodealliance:main:

cc @pchickey

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 16:19):

brendandburns requested alexcrichton for a review on PR #6495.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 16:19):

brendandburns requested wasmtime-core-reviewers for a review on PR #6495.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 16:19):

brendandburns requested wasmtime-default-reviewers for a review on PR #6495.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 19:03):

alexcrichton requested pchickey for a review on PR #6495.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 20:33):

pchickey submitted PR review:

Thanks! Alex pointed out the line in the test-programs build.rs that needs to be fixed, or better yet just remove that whole const and inline the if's body, since it was just a temporary fix.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 20:33):

pchickey submitted PR review:

Thanks! Alex pointed out the line in the test-programs build.rs that needs to be fixed, or better yet just remove that whole const and inline the if's body, since it was just a temporary fix.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 20:33):

pchickey created PR review comment:

We don't actually use this feature anymore, and its an oversight that it is still present in test-programs/Cargo.toml. (Once the component model was needed to build the wasi tests, there was no reason to gate the component-model feature on just http, so one feature for building all tests is sufficient.)

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 21:09):

brendandburns updated PR #6495.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 21:09):

brendandburns created PR review comment:

removed.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 23:16):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 23:58):

pchickey merged PR #6495.

Last updated: Nov 22 2024 at 17:03 UTC