brendandburns opened PR #6495 from brendandburns:renable
to bytecodealliance:main
:
cc @pchickey
brendandburns requested alexcrichton for a review on PR #6495.
brendandburns requested wasmtime-core-reviewers for a review on PR #6495.
brendandburns requested wasmtime-default-reviewers for a review on PR #6495.
alexcrichton requested pchickey for a review on PR #6495.
pchickey submitted PR review:
Thanks! Alex pointed out the line in the test-programs build.rs that needs to be fixed, or better yet just remove that whole const and inline the if's body, since it was just a temporary fix.
pchickey submitted PR review:
Thanks! Alex pointed out the line in the test-programs build.rs that needs to be fixed, or better yet just remove that whole const and inline the if's body, since it was just a temporary fix.
pchickey created PR review comment:
We don't actually use this feature anymore, and its an oversight that it is still present in
test-programs/Cargo.toml
. (Once the component model was needed to build the wasi tests, there was no reason to gate the component-model feature on just http, so one feature for building all tests is sufficient.)
brendandburns updated PR #6495.
brendandburns created PR review comment:
removed.
pchickey submitted PR review.
pchickey merged PR #6495.
Last updated: Dec 23 2024 at 12:05 UTC