Stream: git-wasmtime

Topic: wasmtime / PR #6494 Fix `execute_across_threads` in tests


view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 15:54):

alexcrichton requested itsrainy for a review on PR #6494.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 15:54):

alexcrichton opened PR #6494 from alexcrichton:fix-execute-across-threads to bytecodealliance:main:

This commit fixes the helper function execute_across_threads in tests to actually execute across threads. This function was refactored in #3975 and accidentally introduced a bug where the future provided was polled once and then dropped, cancelling it instead of executing it to completion.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 15:54):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6494.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 16:01):

itsrainy submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 17:02):

alexcrichton merged PR #6494.


Last updated: Dec 23 2024 at 12:05 UTC