Stream: git-wasmtime

Topic: wasmtime / PR #6489 x64: Don't require SSE4.1 for `enable...

Wasmtime GitHub notifications bot (May 31 2023 at 21:25):

alexcrichton opened PR #6489 from alexcrichton:x64-ssse3 to bytecodealliance:main:

This commit removes the SSE4.1 requirement for the enable_simd CLIF feature. This means that the new baseline required is SSSE3 for the WebAssembly SIMD proposal. Many existing tests for codegen were all updated to explicitly enable has_sse41 and runtests were updated to test with and without SSE 4.1.

Wasmtime's fuzzing is additionally updated to flip the SSE4.1 feature to enable fuzz-testing this.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 31 2023 at 21:25):

alexcrichton requested cfallin for a review on PR #6489.

Wasmtime GitHub notifications bot (May 31 2023 at 21:25):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6489.

Wasmtime GitHub notifications bot (May 31 2023 at 21:25):

alexcrichton requested jameysharp for a review on PR #6489.

Wasmtime GitHub notifications bot (May 31 2023 at 21:25):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6489.

Wasmtime GitHub notifications bot (May 31 2023 at 21:26):

alexcrichton created PR review comment:

Note that this bug fix isn't directly related to this PR but it affected one test. Specifically the bug was that if there were two target-specific options the second one would be discarded because parse_options would only return one error for the first one it didn't recognize for the top-level flags. Now this unconditionally parses all flags which is, I believe, the intended behavior.

Wasmtime GitHub notifications bot (Jun 01 2023 at 14:02):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jun 01 2023 at 16:02):

alexcrichton merged PR #6489.

Last updated: Nov 22 2024 at 17:03 UTC