Stream: git-wasmtime

Topic: wasmtime / PR #6487 Add support to Winch for integer comp...

Wasmtime GitHub notifications bot (May 31 2023 at 19:06):

jeffcharles opened PR #6487 from jeffcharles:winch-add-int-cmps to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
This change introduces support for binary comparison instructions for i32s and i64s to Winch.

To accomplish this, I introduce a cmp_with_set method on the macro assembler that emits a cmp instruction or equivalent, emits an instruction to clear the destination register, and emits an instruction to set the destination register to 0 or 1 depending on the kind of comparison.

Wasmtime GitHub notifications bot (May 31 2023 at 19:06):

jeffcharles requested elliottt for a review on PR #6487.

Wasmtime GitHub notifications bot (May 31 2023 at 19:06):

jeffcharles requested wasmtime-fuzz-reviewers for a review on PR #6487.

Wasmtime GitHub notifications bot (May 31 2023 at 19:06):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #6487.

Wasmtime GitHub notifications bot (May 31 2023 at 20:21):

saulecabrera submitted PR review:

Left a small suggestion regarding documentation. Otherwise this looks reasonable to me.

Wasmtime GitHub notifications bot (May 31 2023 at 20:21):

saulecabrera submitted PR review:

Left a small suggestion regarding documentation. Otherwise this looks reasonable to me.

Wasmtime GitHub notifications bot (May 31 2023 at 20:21):

saulecabrera created PR review comment:

    /// Compare two operands and put the result in dst.

Wasmtime GitHub notifications bot (May 31 2023 at 20:21):

saulecabrera created PR review comment:

Perhaps could we also add a comment stating that in some architectures(x64), this function will emit a series of instructions and update the destination with the result of the comparison?

Wasmtime GitHub notifications bot (May 31 2023 at 20:52):

jeffcharles updated PR #6487.

Wasmtime GitHub notifications bot (May 31 2023 at 21:47):

jeffcharles updated PR #6487.

Wasmtime GitHub notifications bot (May 31 2023 at 21:56):

saulecabrera has enabled auto merge for PR #6487.

Wasmtime GitHub notifications bot (May 31 2023 at 22:45):

saulecabrera merged PR #6487.

Last updated: Dec 23 2024 at 12:05 UTC