Stream: git-wasmtime

Topic: wasmtime / PR #6486 refactor: reorganize WIT and dependen...

Wasmtime GitHub notifications bot (May 31 2023 at 18:43):

rvolosatovs opened PR #6486 from rvolosatovs:fix/cargo-vendor to bytecodealliance:main:

Refs #6390

• move crates/wasi/wit/deps/preview to crates/wasi/wit, since preview package is the WASI package
• fix cargo vendor use cases (downstream crates utilizing Wasmtime via cargo vendor) by ensuring that all WIT-using crates are self-contained

Wasmtime GitHub notifications bot (May 31 2023 at 18:44):

rvolosatovs edited PR #6486:

Refs #6390

• update outdated WIT files
• move crates/wasi/wit/deps/preview to crates/wasi/wit, since preview package is the WASI package
• fix cargo vendor use cases (downstream crates utilizing Wasmtime via cargo vendor) by ensuring that all WIT-using crates are self-contained

Wasmtime GitHub notifications bot (May 31 2023 at 18:53):

rvolosatovs updated PR #6486.

Wasmtime GitHub notifications bot (May 31 2023 at 18:54):

rvolosatovs edited PR #6486:

Refs #6390

• update outdated WIT files
• move crates/wasi/wit/deps/preview to crates/wasi/wit, since preview package is the WASI package
• fix cargo vendor use cases (downstream crates utilizing Wasmtime via cargo vendor) by ensuring that all WIT-using crates are self-contained
• use consistent naming and location scheme for dependencies (e.g. deps/cli-base for wasi:cli-base, just like deps/io is used for wasi:io)

Wasmtime GitHub notifications bot (May 31 2023 at 19:03):

rvolosatovs updated PR #6486.

Wasmtime GitHub notifications bot (May 31 2023 at 19:12):

rvolosatovs updated PR #6486.

Wasmtime GitHub notifications bot (May 31 2023 at 19:20):

rvolosatovs edited PR #6486:

Refs #6390

I used https://github.com/bytecodealliance/wit-deps to populate the wit/deps directories, I checked in the corresponding deps.toml and deps.lock files for future wit-deps update usage, but I did not add a dependency on the tool (yet?) by either build.rs integration or direct binary usage like was requested in https://github.com/bytecodealliance/preview2-prototyping/pull/136 earlier

I also did not touch crates/wasi/wit, since it's using dependency versions, which are different from upstream

• update outdated WIT files
• move crates/wasi/wit/deps/preview to crates/wasi/wit, since preview package is the WASI package
• fix cargo vendor use cases (downstream crates utilizing Wasmtime via cargo vendor) by ensuring that all WIT-using crates are self-contained
• use consistent naming and location scheme for dependencies (e.g. deps/cli-base for wasi:cli-base, just like deps/io is used for wasi:io)

Wasmtime GitHub notifications bot (May 31 2023 at 19:20):

rvolosatovs edited PR #6486:

Refs #6390

I used https://github.com/bytecodealliance/wit-deps to populate the wit/deps directories, I checked in the corresponding deps.toml and deps.lock files for future wit-deps update usage, but I did not add a dependency on the tool (yet?) by either build.rs integration or direct binary usage like was requested in https://github.com/bytecodealliance/preview2-prototyping/pull/136 earlier

I also did not touch crates/wasi/wit/deps other than preview, since package is using dependency versions, which are different from upstream

• update outdated WIT files
• move crates/wasi/wit/deps/preview to crates/wasi/wit, since preview package is the WASI package
• fix cargo vendor use cases (downstream crates utilizing Wasmtime via cargo vendor) by ensuring that all WIT-using crates are self-contained
• use consistent naming and location scheme for dependencies (e.g. deps/cli-base for wasi:cli-base, just like deps/io is used for wasi:io)

Last updated: Nov 22 2024 at 16:03 UTC