Wasmtime GitHub notifications bot (May 31 2023 at 01:02): Wasmtime GitHub notifications bot (May 31 2023 at 01:02):elliottt opened PR #6482 from elliottt:trevor/remove-trailing-space-tests to bytecodealliance:main:
Avoid generating lines with trailing space when updating precise-output compilation tests.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 31 2023 at 01:05):elliottt updated PR #6482.
Wasmtime GitHub notifications bot (May 31 2023 at 01:06):elliottt edited PR #6482:
Avoid generating lines with trailing space when updating precise-output compilation tests. This came up as a comment on #6461.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 31 2023 at 01:08):elliottt updated PR #6482.
Wasmtime GitHub notifications bot (May 31 2023 at 01:09):elliottt edited PR #6482:
Avoid generating lines with trailing space when updating precise-output compilation tests. This came up as a comment on #6461.
I'd recommend reviewing by commit. The first commit in the series is the change that avoids emitting
;lines in the precise-output tests, the second removes some miscellaneous trailing whitespace from tests, and the last commit is the bulk update of all precise-output tests to no longer emit lines with trailing whitespace.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 31 2023 at 01:11):elliottt updated PR #6482.
Wasmtime GitHub notifications bot (May 31 2023 at 01:17):elliottt updated PR #6482.
Wasmtime GitHub notifications bot (May 31 2023 at 01:18):elliottt requested alexcrichton for a review on PR #6482.
Wasmtime GitHub notifications bot (May 31 2023 at 01:18):elliottt has marked PR #6482 as ready for review.
Wasmtime GitHub notifications bot (May 31 2023 at 01:18):elliottt requested jameysharp for a review on PR #6482.
Wasmtime GitHub notifications bot (May 31 2023 at 01:18):elliottt requested wasmtime-compiler-reviewers for a review on PR #6482.
Wasmtime GitHub notifications bot (May 31 2023 at 14:37):alexcrichton submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (May 31 2023 at 15:18):alexcrichton merged PR #6482.
Last updated: Oct 23 2024 at 20:03 UTC