martindevans opened PR #6480 from martindevans:android-release-binaries
to bytecodealliance:main
:
As discussed here. This adds Android targets to the build matrix (Android aarch64 and x86_64) and adds Android to the docs in "tier3". This will make wasmtime more convenient to use on Android devices.
I'm not very familiar with Github actions, so it's very possible that this isn't correct. Unfortunately I wasn't able to work out how to run this action in my fork to test it. If anyone can offer guidance on how to do that it would be much appreciated!
alexcrichton submitted PR review:
Thanks!
Can you add a commit to this PR which has "prtest:full" in its commit message somewhere? That way this PR's CI will run the build step which can help weed out issues and ensure everything looks good too.
alexcrichton submitted PR review:
Thanks!
Can you add a commit to this PR which has "prtest:full" in its commit message somewhere? That way this PR's CI will run the build step which can help weed out issues and ensure everything looks good too.
alexcrichton created PR review comment:
I think these two lines can be omitted due to the step just above these
alexcrichton created PR review comment:
I think this can be omitted since this is a build step rather than a "check" step
alexcrichton created PR review comment:
Could this happen only if the
matrix.target
field contains "android"?
alexcrichton created PR review comment:
Similar to above, could this happen only for android targets? (avoids installing it for all "build" builders)
martindevans updated PR #6480.
martindevans updated PR #6480.
martindevans updated PR #6480.
martindevans updated PR #6480.
martindevans updated PR #6480.
martindevans updated PR #6480.
martindevans updated PR #6480.
martindevans updated PR #6480.
martindevans updated PR #6480.
martindevans closed without merge PR #6480.
Last updated: Dec 23 2024 at 12:05 UTC