Stream: git-wasmtime

Topic: wasmtime / PR #6480 Android release binaries

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2023 at 23:23):

martindevans opened PR #6480 from martindevans:android-release-binaries to bytecodealliance:main:

As discussed here. This adds Android targets to the build matrix (Android aarch64 and x86_64) and adds Android to the docs in "tier3". This will make wasmtime more convenient to use on Android devices.

I'm not very familiar with Github actions, so it's very possible that this isn't correct. Unfortunately I wasn't able to work out how to run this action in my fork to test it. If anyone can offer guidance on how to do that it would be much appreciated!

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2023 at 14:54):

alexcrichton submitted PR review:

Thanks!

Can you add a commit to this PR which has "prtest:full" in its commit message somewhere? That way this PR's CI will run the build step which can help weed out issues and ensure everything looks good too.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2023 at 14:54):

alexcrichton submitted PR review:

Thanks!

Can you add a commit to this PR which has "prtest:full" in its commit message somewhere? That way this PR's CI will run the build step which can help weed out issues and ensure everything looks good too.

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2023 at 14:54):

alexcrichton created PR review comment:

I think these two lines can be omitted due to the step just above these

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2023 at 14:54):

alexcrichton created PR review comment:

I think this can be omitted since this is a build step rather than a "check" step

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2023 at 14:54):

alexcrichton created PR review comment:

Could this happen only if the matrix.target field contains "android"?

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2023 at 14:54):

alexcrichton created PR review comment:

Similar to above, could this happen only for android targets? (avoids installing it for all "build" builders)

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 12:43):

martindevans updated PR #6480.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 13:05):

martindevans updated PR #6480.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 13:15):

martindevans updated PR #6480.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 13:27):

martindevans updated PR #6480.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 01 2023 at 13:57):

martindevans updated PR #6480.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 11 2023 at 22:39):

martindevans updated PR #6480.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 13 2023 at 01:12):

martindevans updated PR #6480.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 12 2023 at 14:00):

martindevans updated PR #6480.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 12 2023 at 14:13):

martindevans updated PR #6480.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 20:33):

martindevans closed without merge PR #6480.

Last updated: Oct 23 2024 at 20:03 UTC