Wasmtime GitHub notifications bot (May 30 2023 at 22:52): Wasmtime GitHub notifications bot (May 30 2023 at 22:52):pchickey edited PR #6479:
Backport of fixes added to #6463.
Fix to the fixes that became 9.0.2 release: #6462 and #6471. We intend to merge this PR and ship it as patch release 9.0.3.
In order to work with wasi-testsuite, it needs to be possible to
path_open(dirfd, ".", ...) with the same rights reported in the
fdstat of that dirfd. When we report the Rights::all() set, both
FD_READ and FD_WRITE are set in the base rights, which results in
unix rejecting an openat2(dirfd, ".", O_RDWR) with EISDIR.By not having the FD_READ and FD_WRITE rights present in the base
rights, the open syscall defaults to O_RDONLY, which is the only
access mode allowed for opening directories.Note: wasi-testsuite is used to test our wasi-common implementation upstream, but not in this release branch, which is why this problem did not get caught before releasing 9.0.2.
Wasmtime GitHub notifications bot (May 31 2023 at 00:19):pchickey updated PR #6479.
Wasmtime GitHub notifications bot (May 31 2023 at 16:19):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (May 31 2023 at 16:50):pchickey merged PR #6479.
Last updated: Dec 23 2024 at 12:05 UTC