Stream: git-wasmtime

Topic: wasmtime / PR #6479 Pch/release 9 fix dir open rights

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2023 at 22:34):

pchickey opened PR #6479 from bytecodealliance:pch/release-9-fix-dir-open-rights to bytecodealliance:release-9.0.0:

Backport of fixes added to #6463.

Fix to the fixes that became 9.0.2 release: #6462 and #6471. We intend to merge this PR and ship it as patch release 9.0.3.

In order to work with wasi-testsuite, it needs to be possible to
path_open(dirfd, ".", ...) with the same rights reported in the
fdstat of that dirfd. When we report the Rights::all() set, both
FD_READ and FD_WRITE are set in the base rights, which results in
unix rejecting an openat2(dirfd, ".", O_RDWR) with EISDIR.

By not having the FD_READ and FD_WRITE rights present in the base
rights, the open syscall defaults to O_RDONLY, which is the only
access mode allowed for opening directories.

Note: wasi-testsuite is used to test our wasi-common implementation upstream, but not in this release branch, which is why this problem did not get caught before releasing 9.0.2.

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2023 at 22:34):

pchickey requested fitzgen for a review on PR #6479.

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2023 at 22:34):

pchickey requested wasmtime-core-reviewers for a review on PR #6479.

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2023 at 22:35):

pchickey requested sunfishcode for a review on PR #6479.

Last updated: Dec 23 2024 at 12:05 UTC