Stream: git-wasmtime

Topic: wasmtime / PR #6476 riscv64: Cleanup shift rules

Wasmtime GitHub notifications bot (May 27 2023 at 10:41):

afonso360 opened PR #6476 from afonso360:riscv-shifts-cleanup to bytecodealliance:main:

:wave: Hey,

This is a small cleanup to the shift rules, we had a few rules that lowered to the same instruction and that could be de-duplicated. Additionally this also does a few improvements in certain cases:

• We were missing some opportunities to encode the shift amount into the shift instruction
• Additionally we now look through uextend's on the shift amounts to find even more inlining opportunities

The first commit adds the tests with the current lowerings, and the follow up commits show how the codegen changes.

Wasmtime GitHub notifications bot (May 27 2023 at 10:41):

afonso360 requested abrown for a review on PR #6476.

Wasmtime GitHub notifications bot (May 27 2023 at 10:41):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6476.

Wasmtime GitHub notifications bot (May 27 2023 at 10:48):

afonso360 edited PR #6476:

:wave: Hey,

This is a small cleanup to the shift rules, we had a few rules that lowered to the same instruction and that could be de-duplicated. Additionally we now look through uextend's on the shift amounts to find even more inlining opportunities

The first commit adds the tests with the current lowerings, and the follow up commits show how the codegen changes.

Wasmtime GitHub notifications bot (May 27 2023 at 10:54):

afonso360 updated PR #6476.

Wasmtime GitHub notifications bot (May 31 2023 at 15:00):

alexcrichton submitted PR review:

Nice!

Definitely appreciate the commit separation, made this quite easy to review :+1:

Wasmtime GitHub notifications bot (Jun 01 2023 at 19:01):

afonso360 updated PR #6476.

Wasmtime GitHub notifications bot (Jun 01 2023 at 19:05):

afonso360 updated PR #6476.

Wasmtime GitHub notifications bot (Jun 01 2023 at 19:06):

afonso360 has enabled auto merge for PR #6476.

Wasmtime GitHub notifications bot (Jun 02 2023 at 09:58):

afonso360 updated PR #6476.

Wasmtime GitHub notifications bot (Jun 02 2023 at 11:06):

afonso360 merged PR #6476.

Last updated: Dec 23 2024 at 12:05 UTC