Stream: git-wasmtime

Topic: wasmtime / PR #6466 x64: Move instruction helpers together

view this post on Zulip Wasmtime GitHub notifications bot (May 26 2023 at 15:34):

alexcrichton opened PR #6466 from alexcrichton:x64-minor-refactor to bytecodealliance:main:

Currently helpers for emitting an MInst are interspersed throughout the actual instruction constructors of the form x64_*. This commit centralizes all of these helpers to one section of inst.isle to make it a bit easier to organize them and more clear where to add new ones.

A few minor refactorings were performed as well for two new constructors which are now used in instruction lowerings.

view this post on Zulip Wasmtime GitHub notifications bot (May 26 2023 at 15:34):

alexcrichton requested jameysharp for a review on PR #6466.

view this post on Zulip Wasmtime GitHub notifications bot (May 26 2023 at 15:34):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6466.

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2023 at 23:17):

jameysharp submitted PR review:

Yes, this looks like a nice cleanup. Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (May 31 2023 at 15:11):

alexcrichton merged PR #6466.

Last updated: Nov 22 2024 at 16:03 UTC