Stream: git-wasmtime

Topic: wasmtime / PR #6460 Fix adapter build on CI, rename the a...

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2023 at 21:22):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6460.

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2023 at 21:22):

alexcrichton requested wasmtime-default-reviewers for a review on PR #6460.

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2023 at 21:22):

alexcrichton opened PR #6460 from alexcrichton:fix-adapter to bytecodealliance:main:

This fixes an issue on main where the adapter is not validating currently. This slipped through because the GitHub Actions job was accidentally not listed in the "join" step of CI so nothing in our merge queue configuration was requiring it to succeed.

While I was here I went ahead and renamed the adapters as well to wasi_snapshot_preview1.command.wasm (and reactor) to match what wit-component expects as an --adapt argument where the basename of the provided file is used as the default name of what to adapt.

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2023 at 21:22):

alexcrichton requested pchickey for a review on PR #6460.

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2023 at 21:48):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2023 at 21:51):

alexcrichton updated PR #6460.

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2023 at 21:51):

alexcrichton has enabled auto merge for PR #6460.

view this post on Zulip Wasmtime GitHub notifications bot (May 25 2023 at 22:49):

alexcrichton merged PR #6460.

Last updated: Dec 23 2024 at 12:05 UTC