wasmtime / PR #6453 feat(preview1): implement `fd_readdir` · git-wasmtime

Refs #6370 https://github.com/bytecodealliance/wasmtime/pull/6454

This includes a few somewhat related fixes in the host adapter, including fd_close fix bringing the host adapter almost to feature parity with component adapter.

@pchickey will handle sockets and polling, at which point this whole work should be done

Wasmtime GitHub notifications bot (May 25 2023 at 17:13):

rvolosatovs updated PR #6453.

Wasmtime GitHub notifications bot (May 25 2023 at 18:02):

rvolosatovs updated PR #6453.

Wasmtime GitHub notifications bot (May 25 2023 at 18:54):

rvolosatovs updated PR #6453.

Wasmtime GitHub notifications bot (May 25 2023 at 18:55):

rvolosatovs updated PR #6453.

Wasmtime GitHub notifications bot (May 25 2023 at 19:01):

rvolosatovs updated PR #6453.

Wasmtime GitHub notifications bot (May 25 2023 at 19:33):

rvolosatovs updated PR #6453.

Wasmtime GitHub notifications bot (May 25 2023 at 20:05):

rvolosatovs has marked PR #6453 as ready for review.

Wasmtime GitHub notifications bot (May 25 2023 at 23:47):

pchickey submitted PR review:

Great work!

Wasmtime GitHub notifications bot (May 25 2023 at 23:47):

pchickey submitted PR review:

Great work!

Wasmtime GitHub notifications bot (May 25 2023 at 23:47):

pchickey created PR review comment:

That is unfortunate, I never knew about this bug.

I am not sure what to do with this. We decided to get rid of providing .. in the entries stream in preview 2, because it doesn't really fit the capability model - a preopen doesn't have a ... I don't think we have any way to implement this correctly, so I guess we just have to hope that this bug doesn't cause problems for userland

Wasmtime GitHub notifications bot (May 25 2023 at 23:47):

pchickey created PR review comment:

Thanks, I never write this syntax so I missed it.

Wasmtime GitHub notifications bot (May 25 2023 at 23:47):

pchickey created PR review comment:

                    d_ino: fd_inode.to_le(), // NOTE: incorrect, but legacy implementation returns `fd` inode here

Wasmtime GitHub notifications bot (May 25 2023 at 23:47):

pchickey created PR review comment:

            // remove iterator from table and use it directly:
            .delete_readdir(stream)?

Wasmtime GitHub notifications bot (May 26 2023 at 09:18):

rvolosatovs updated PR #6453.

Wasmtime GitHub notifications bot (May 26 2023 at 09:21):

rvolosatovs requested pchickey for a review on PR #6453.

Wasmtime GitHub notifications bot (May 26 2023 at 15:47):

pchickey merged PR #6453.

Last updated: Oct 23 2024 at 20:03 UTC