Stream: git-wasmtime

Topic: wasmtime / PR #6451 winch: Refactor the `MacroAssembler` ...

Wasmtime GitHub notifications bot (May 24 2023 at 22:21):

saulecabrera opened PR #6451 from saulecabrera:winch-refactor-abi-ptrsize-masm to bytecodealliance:main:

This commit is a follow up to https://github.com/bytecodealliance/wasmtime/pull/6443, in which we discussed potentially having PtrSize and ABI as associated types to the MacroAssembler trait.

I considered having PtrSize associated to the ABI, but given the amount of ABI details needed at the MacroAssembler level, I decided to go with the approach in this change.

The chosen approach ended up cutting a decent amount of boilerplate from the MacroAssembler itself, but also from each of the touchpoints where the MacroAssembler is used.

This change also standardizes the signatures of the ABI trait. Some of them borrowed &self and some didn't, but in practice, there's no need to have any of them borrow &self.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 24 2023 at 22:21):

saulecabrera requested alexcrichton for a review on PR #6451.

Wasmtime GitHub notifications bot (May 24 2023 at 22:21):

saulecabrera requested cfallin for a review on PR #6451.

Wasmtime GitHub notifications bot (May 24 2023 at 22:21):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #6451.

Wasmtime GitHub notifications bot (May 24 2023 at 22:48):

saulecabrera updated PR #6451.

Wasmtime GitHub notifications bot (May 25 2023 at 15:13):

alexcrichton submitted PR review:

Nice!

Wasmtime GitHub notifications bot (May 25 2023 at 16:33):

saulecabrera merged PR #6451.

Last updated: Oct 23 2024 at 20:03 UTC