saulecabrera opened PR #6451 from saulecabrera:winch-refactor-abi-ptrsize-masm
to bytecodealliance:main
:
This commit is a follow up to https://github.com/bytecodealliance/wasmtime/pull/6443, in which we discussed potentially having
PtrSize
andABI
as associated types to theMacroAssembler
trait.I considered having
PtrSize
associated to theABI
, but given the amount of ABI details needed at theMacroAssembler
level, I decided to go with the approach in this change.The chosen approach ended up cutting a decent amount of boilerplate from the
MacroAssembler
itself, but also from each of the touchpoints where theMacroAssembler
is used.This change also standardizes the signatures of the
ABI
trait. Some of them borrowed&self
and some didn't, but in practice, there's no need to have any of them borrow&self
.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
saulecabrera requested alexcrichton for a review on PR #6451.
saulecabrera requested cfallin for a review on PR #6451.
saulecabrera requested wasmtime-compiler-reviewers for a review on PR #6451.
saulecabrera updated PR #6451.
alexcrichton submitted PR review:
Nice!
saulecabrera merged PR #6451.
Last updated: Dec 23 2024 at 12:05 UTC