Wasmtime GitHub notifications bot (May 22 2023 at 19:24): Wasmtime GitHub notifications bot (May 22 2023 at 19:24):saulecabrera opened PR #6432 from saulecabrera:winch-refactor-fuzzing to bytecodealliance:main:
This change is a follow-up to the discussion in
https://github.com/bytecodealliance/wasmtime/pull/6281.The most notable characteristic of this change is that it enables
winchby default in the fuzzers. If compilation time is a big enough concern I can add the cargo feature back. I opted to enablewinchby default for several reasons:
It substantially reduces the
cfgcomplexity -- at first I thought I had covered all the places in which acfgcheck would be needed, but then I realized that I missed the Cranelift specific compiler flags.It's the fastest route to enable winch by default in the fuzzers, which we want to do eventually -- the only change we'd need at that point would be to get rid of the winch-specific environment variable.
We can get rid of the winch-specific checks in CI for fuzzing
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (May 22 2023 at 19:24):saulecabrera requested alexcrichton for a review on PR #6432.
Wasmtime GitHub notifications bot (May 22 2023 at 19:24):saulecabrera requested wasmtime-fuzz-reviewers for a review on PR #6432.
Wasmtime GitHub notifications bot (May 22 2023 at 19:24):saulecabrera requested wasmtime-core-reviewers for a review on PR #6432.
Wasmtime GitHub notifications bot (May 22 2023 at 19:24):saulecabrera requested wasmtime-default-reviewers for a review on PR #6432.
Wasmtime GitHub notifications bot (May 22 2023 at 19:52):alexcrichton submitted PR review:
To confirm, this'll mean that winch will get OSS-Fuzz thrown at it, and wanted to confirm that's ok? I'm happy to ferry bugs from oss-fuzz into issues and cc you, but wanted to make sure you're ok being on the hook for them.
Wasmtime GitHub notifications bot (May 22 2023 at 22:37):saulecabrera updated PR #6432.
Wasmtime GitHub notifications bot (May 22 2023 at 22:50):saulecabrera requested alexcrichton for a review on PR #6432.
Wasmtime GitHub notifications bot (May 23 2023 at 13:32):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (May 23 2023 at 14:12):alexcrichton merged PR #6432.
Last updated: Nov 22 2024 at 16:03 UTC