Stream: git-wasmtime

Topic: wasmtime / PR #6414 `cranelift-codegen`: Rename `abi::Cal...

Wasmtime GitHub notifications bot (May 18 2023 at 19:40):

fitzgen opened PR #6414 from fitzgen:no-caller-callee to bytecodealliance:main:

Will be less confusing since each call site has both a caller and a callee.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 18 2023 at 19:40):

fitzgen requested cfallin for a review on PR #6414.

Wasmtime GitHub notifications bot (May 18 2023 at 19:40):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #6414.

Wasmtime GitHub notifications bot (May 18 2023 at 19:41):

fitzgen updated PR #6414.

Wasmtime GitHub notifications bot (May 18 2023 at 19:41):

fitzgen edited PR #6414:

Will be less confusing since each call site has both a caller and a callee.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (May 18 2023 at 20:00):

fitzgen updated PR #6414.

Wasmtime GitHub notifications bot (May 18 2023 at 20:16):

cfallin submitted PR review:

This seems fine to me; @fitzgen and I talked it over and tried to brainstorm better names a bit yesterday and this is I think the clearest option.

Just to document a little history here: Caller (née ABICaller) was previously ABICall and Callee (née ABICallee) was previously ABIBody; the last rename happened in #2142 after some review comments; specifically here was where caller/callee were suggested, because "call" was confusing. Perhaps "callsite" is a bit better / more explicit though.

Wasmtime GitHub notifications bot (May 19 2023 at 06:26):

alexcrichton merged PR #6414.

Last updated: Dec 23 2024 at 12:05 UTC